feat: add popover, dropdown-menu components; update badge, tooltip, s… - #444
Merged
IbrahimIjai merged 2 commits intoJul 27, 2026
Merged
Conversation
|
@Darkvader-ship-it is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Darkvader-ship-it Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- badge: keep structural size variants with upstream's semantic colors + text-10 token - tooltip: keep overlay surface tokens (bg-popover/ring) with upstream's comment - globals: merge all tokens (upstream's success/warning/info + foregrounds, long/short; add neutral, danger) and upstream's chart/layout variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #410
closes #411
closes #412
closes #413
Dropdown Menu Component – Summary
All checks pass.
packages/ui/src/components/dropdown-menu.tsx— New component with 11 exported parts:DropdownMenuDropdownMenuTriggerDropdownMenuContentbg-popover/shadow-mdoverlay surface, collision-aware positioningDropdownMenuItemdestructiveprop — visually distinct viatext-destructive/bg-destructive/10on highlight, not selected by defaultDropdownMenuCheckboxItemCheckmarkCircle01Icon)DropdownMenuRadioGroupvalue/onValueChangeDropdownMenuRadioItemRadioButtonIconindicatorDropdownMenuGroupDropdownMenuGroupLabelDropdownMenuSeparatorDropdownMenuShortcut<span>withml-autoright alignment)Key Behaviors (covered by Base UI Menu)
labelpropTests